fix: cross-platform compatibility and improved setup experience - #21
Open
pocikode wants to merge 1 commit into
Open
fix: cross-platform compatibility and improved setup experience#21pocikode wants to merge 1 commit into
pocikode wants to merge 1 commit into
Conversation
- Fix Windows-only backslash path separator in helpers/mic.py (use os.path.join) - Add .env.example to project root for easier discovery - Add VOSK model existence check with helpful error message - Improve README with step-by-step setup instructions including VOSK download - Use os.path.join for all file paths in main.py Fixes dot-Justin#7
Author
|
/claim #7 |
|
🤝 You already claimed this issue, you don't have to do it again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7
The main issue: this project does not work on macOS/Linux out of the box.
What I changed:
helpers/mic.py — The config path was hardcoded with Windows backslashes. Swapped to
os.path.joinso it works everywhere.main.py — Same deal with the VOSK model path. Also added a check so you get a clear error message if the model is not downloaded yet, instead of a random traceback.
.env.example — Added one in the project root. The existing one was buried in
helpers/butload_dotenv()looks in the working directory. Now users can justcp .env.example .envand edit.README — Rewrote the setup section with actual step-by-step instructions. The original was missing the VOSK download step entirely, which is probably why #7 was opened.